Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] Command-line tools for every chroma-load endpoint. #3221

Merged
merged 4 commits into from
Dec 3, 2024
Merged

[ENH] Command-line tools for every chroma-load endpoint. #3221

merged 4 commits into from
Dec 3, 2024

Conversation

rescrv
Copy link
Contributor

@rescrv rescrv commented Dec 2, 2024

chroma-load-start start a workload
chroma-load-stop stop a workload
chroma-load-inhibit stop all workloads
chroma-load-uninhibit reverse the effects of chroma-load-inhibit

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 2, 2024

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@rescrv rescrv requested review from Sicheng-Pan and eculver December 2, 2024 17:36
@Sicheng-Pan
Copy link
Contributor

I'm wondering if there is a readme or --help option that shows how these tools should be used?

@rescrv
Copy link
Contributor Author

rescrv commented Dec 2, 2024

Providing --help will give the arguments. I plan to write runbooks for these tools once they are packaged and working.

eculver
eculver approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@eculver eculver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as core functionality, this looks good. I don't have any blockers.

Sicheng-Pan
Sicheng-Pan approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@Sicheng-Pan Sicheng-Pan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

rescrv added 4 commits December 2, 2024 17:05
@rescrv
[ENH] Command-line tools for every chroma-load endpoint.
3568a4e 
chroma-load-start       start a workload
chroma-load-stop        stop a workload
chroma-load-inhibit     stop all workloads
chroma-load-uninhibit   reverse the effects of chroma-load-inhibit
@rescrv
status tool
d807065
@rescrv
status tool prints useful status
cdbf0a9
@rescrv
Make start print the uuid of started task.
4527646
@rescrv rescrv merged commit 0de90da into rescrv/load4 Dec 3, 2024
71 checks passed
@rescrv rescrv deleted the rescrv/load5 branch December 3, 2024 16:21
rescrv added a commit that referenced this pull request Dec 3, 2024
@rescrv
[ENH] Command-line tools for every chroma-load endpoint. (#3221)
1f5132d 
chroma-load-start       start a workload
chroma-load-stop        stop a workload
chroma-load-inhibit     stop all workloads
chroma-load-uninhibit   reverse the effects of chroma-load-inhibit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sicheng-Pan Sicheng-Pan Sicheng-Pan approved these changes

@eculver eculver eculver approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rescrv @Sicheng-Pan @eculver